fix: correct import path and add missing logging in groq example#404
Open
majiayu000 wants to merge 1 commit intostanford-oval:mainfrom
Open
fix: correct import path and add missing logging in groq example#404majiayu000 wants to merge 1 commit intostanford-oval:mainfrom
majiayu000 wants to merge 1 commit intostanford-oval:mainfrom
Conversation
- Fix incorrect import statement: change `import lm; from lm import GroqModel` to `from knowledge_storm.lm import GroqModel` - Add missing `import logging` and logger initialization - Remove incorrect docstring about VLLM server (this is a Groq example) This fixes the ImportError when running the groq example script. Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_storm_wiki_groq.pyChanges
import lm; from lm import GroqModeltofrom knowledge_storm.lm import GroqModelimport loggingandlogger = logging.getLogger(__name__)to fix the undefinedloggererrorTest plan
run_storm_wiki_mistral.py)knowledge_storm/directory, so CI format check should passNote: This addresses the same issue as PR #302, which has merge conflicts and has been stale since January 2025.