Proposed fix of Issue #10064, rolling up nested cost trackers to the parent on closing#10065
Closed
asparagus wants to merge 1 commit into
Closed
Proposed fix of Issue #10064, rolling up nested cost trackers to the parent on closing#10065asparagus wants to merge 1 commit into
asparagus wants to merge 1 commit into
Conversation
…ers to the parent on closing
Contributor
Greptile SummaryThis PR updates usage tracking so nested tracker contexts roll their usage into the parent tracker. The main changes are:
Confidence Score: 5/5Safe to merge with minimal risk. The change is small and localized to usage aggregation. The added test covers the reported nested-tracker behavior. No correctness or security issues were identified in the changed paths. No files require special attention.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "Proposed fix of Issue #10064, rolling up..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rolling up nested cost trackers to the parent on closing
Context
This solves #10064
Caveats
Are any users relying on the current behavior, or already accounting for it?
Testing
Added
tests/utils/test_usage_tracker.py::test_nested_usage_tracker, fixed in the current branch and errors onmainwith: