Skip to content

refactor: Restore QdrantRM #8100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Apr 23, 2025

Description

This PR restores the QdrantRM retriever, which was previously commented out in #1937 due to its reliance on deprecated dsp/* module imports.

To resolve this, all necessary imports have been made inline. This change restores QdrantRM's original functionality.

Signed-off-by: Anush008 <[email protected]>
@okhat
Copy link
Collaborator

okhat commented Apr 23, 2025

Thank you @Anush008 ! Q: Do you think this code should live inside DSPy? It seems like it can just be an external piece of code.

@Anush008
Copy link
Contributor Author

We've had several users of QdrantRM over time. So I propose to keep it. The dependencies are optional.

@okhat
Copy link
Collaborator

okhat commented Apr 23, 2025

We love Qdrant, but this could be a new pip library maybe? pip install dspy-qdrant? It doesn't seem like this should live inside DSPy; it'll get stale etc.

@Anush008
Copy link
Contributor Author

Anush008 commented Apr 23, 2025

I believe a library would be an overkill.
Since there are several retriever implementations in https://github.com/stanfordnlp/dspy/tree/main/dspy/retrieve already, this would be another addition(restoration).

@okhat
Copy link
Collaborator

okhat commented Apr 23, 2025

Oh all of these are getting deleted, see then recent PR: #8073

@Anush008
Copy link
Contributor Author

Oh. Makes sense then. Thanks.

@Anush008 Anush008 closed this Apr 24, 2025
@Anush008 Anush008 deleted the restore-qdrant branch April 24, 2025 03:08
@Anush008
Copy link
Contributor Author

Hey @okhat.
We'll move the retriever to a separate qdrant-dspy package.

@Anush008
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants