Thread Local and Async Local history for BaseLM#9261
Open
TyTodd wants to merge 3 commits intostanfordnlp:mainfrom
Open
Thread Local and Async Local history for BaseLM#9261TyTodd wants to merge 3 commits intostanfordnlp:mainfrom
TyTodd wants to merge 3 commits intostanfordnlp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ran into this use case a couple times now where I need to get the history of a
Predictbut feel uneasy about usingLM.historybecause the same LM is being used in multiple coroutines. The devx for getting a thread safe view of history is a little verbose, you either have to usedspy.contextwith a copy of the global LM. Or run a separate copy of your module if it has itsself.lm. In some (rare) cases even this is not enough. I recently ran into a scenario where I needed to use the same module across multiple co-routines. The module had its ownself.lmso usingdspy.contextwasn't a viable solution since it injects the LM into the localdspy.settings.This short PR adds thread/async-local history to LM via a ContextVar called
local_history. Allowing users to view the history from the local thread.