You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
looks gtm, but let's merge it to a new minor version branch.
With this being a feature we could also simplify the creation of new stanncams. Like instead of having so many extra optional paramters, i'd favor not having those params, but just calling whatever you need to change afterwards in a chain
Makes sense to bundle it with more updates.
So now the question is, do we add getter and setter methods for every stanncam variable? That way there's not a mix of method chaining and dot accessors when creating the stanncam?
Makes sense to bundle it with more updates. So now the question is, do we add getter and setter methods for every stanncam variable? That way there's not a mix of method chaining and dot accessors when creating the stanncam?
I guess that makes most sense. I feel a little conflicted since it might overcomplicate just getting a single variable with a dot accessor. But i don't know if there's any real cases where people actually do that now that i think about it. Plus this doesn't remove that ability i guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79