fix: redefine overloaded virtual methods in derived class #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler errors due to hidden virtual method appear when building the
code against ROOT6.24
```
g++ -m64 -fPIC -pipe -Wall -Woverloaded-virtual -std=c++0x -Wno-long-long -pthread -Werror -O2 -g -falign-loops -falign-jumps -falign-functions -Dsl79_gcc485 -D__ROOT__ -DNEW_DAQ_READER -I. -IStRoot -I.sl79_gcc485/include -I/star/ROOT/6.24.06/geant3/TGeant3 -I/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include -c .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx -o .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.o
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:804:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t)' was hidden [-Werror=overloaded-virtual]
virtual void ProcessEvent(Int_t eventId);
^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error: by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
virtual void ProcessEvent();
^
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:882:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t, Bool_t)' was hidden [-Werror=overloaded-virtual]
virtual void ProcessEvent(Int_t eventId, Bool_t isInterruptible);
^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error: by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
virtual void ProcessEvent();
^
```
iraklic
approved these changes
Nov 3, 2023
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
Compiler errors due to hidden virtual method appear when building the
code against ROOT6.24
```
g++ -m64 -fPIC -pipe -Wall -Woverloaded-virtual -std=c++0x -Wno-long-long -pthread -Werror -O2 -g -falign-loops -falign-jumps -falign-functions -Dsl79_gcc485 -D__ROOT__ -DNEW_DAQ_READER -I. -IStRoot -I.sl79_gcc485/include -I/star/ROOT/6.24.06/geant3/TGeant3 -I/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include -c .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx -o .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.o
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:804:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t)' was hidden [-Werror=overloaded-virtual]
virtual void ProcessEvent(Int_t eventId);
^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error: by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
virtual void ProcessEvent();
^
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:882:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t, Bool_t)' was hidden [-Werror=overloaded-virtual]
virtual void ProcessEvent(Int_t eventId, Bool_t isInterruptible);
^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error: by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
virtual void ProcessEvent();
^
```
See star-bnl#619 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler errors due to hidden virtual method appear when building the
code against ROOT6.24
See #619 for details