Calibrated BBC simulation #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akioogawa
requested review from
dkapukchyan,
gdwebb,
klendathu2k and
plexoos
akioogawa
approved these changes
Nov 20, 2024
Member
Author
|
I'm sorry, I made a mistake for ADCBin = 4096. I apply this factor to the GetADC function |
Contributor
|
Can someone please review (and approve?) |
plexoos
approved these changes
Dec 12, 2024
Member
plexoos
left a comment
plexoos
left a comment
There was a problem hiding this comment.
Unblocking, trusting the team's expertise.
Member
Author
|
Thank you for the approval. If I need to explain it, I will present it in the S&C meeting. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BBC simulation has been calibrated with a 2017 p+p run.
There is added the calibrated factors for all BBC channels.
It was also discussed with Akio.
Thanks