-
Notifications
You must be signed in to change notification settings - Fork 68
Shared library loading in ROOT6 #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…which couldn't possibly cause any side effects, but lets be safe about it shall we?)
…t a library can only be loaded a single time.
…. Mixing between the pragma directives and TSystem::Load appears to result in problems when a library is loaded multiple times.
genevb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StRoot/StBFChain/StBFChain.cxx
Outdated
| #include <map> | ||
| #include <string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you removed the gSharedLibs line that was forcing these includes, so perhaps remove these includes too?
|
They are related, and I think this PR may be needed to resolve the CI issues with #751.
|
|
@klendathu2k Do you use a specific test command to verify the change? If so, could you share it? |
|
setup 64b
setenv GROUP_DIR /star/u/jeromel/work/STAR/group
starver SL24x config/v0.3.0-rhel7-root6.24.06
root4star
... throws no errors.
…On 2025-06-18 11:08, Dmitri Smirnov wrote:
plexoos left a comment (star-bnl/star-sw#753) [1]
@klendathu2k [2] Do you use a specific test command to verify the
change? If so, could you share it?
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[3].
You are receiving this because you were mentioned.Message ID:
***@***.***>
Links:
------
[1]
#753 (comment)
[2] https://github.com/klendathu2k
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVB3X6YWPKWZVMU7T7L3EF6G7AVCNFSM6AAAAAB7NRUTV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBUGYYTSMJQG4
|
|
Thanks! Which commands should I run to reproduce the issue? |
I cannot reproduce the issue. I don't see any problem running the following commands: |
|
@ plexoos , to be clear, you should use the standard NFSv4 GROUP_DIR to experience the issue:
/star/nfs4/AFS/star/group
Jerome made a fix for his GROUP_DIR which he does not consider a final solution.
… On Jun 20, 2025, at 10:13 AM, Dmitri Smirnov ***@***.***> wrote:
I cannot reproduce the issue. I don't see any problem running the following commands:
...
[cvmfswrite01] ~/> setenv GROUP_DIR /star/u/jeromel/work/STAR/group
|
Thanks for pointing that out, Gene. It wasn’t clear to me from the previous messages that GROUP_DIR specifically needed to be set to that path. That said, since I’ve already tested it using the fixed setup scripts and couldn’t reproduce the issue, it makes me wonder: Is there really a need to modify the code, if adjusting the environment resolves it? |
Exclusively use
#pragmastatements to load shared libraries for ROOT6, to avoid problems when we mixTSystem::Loadwith#prama cling load.