Skip to content

Conversation

@klendathu2k
Copy link
Contributor

Exclusively use #pragma statements to load shared libraries for ROOT6, to avoid problems when we mix TSystem::Load with #prama cling load.

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're doing the same thing that you proposed in PR #751 , but that was for a Cling-compiled macro, while this will be for cons-compiled code. I'm not aware of a reason to oppose, other than Dmitri's comments in PR #751 a couple weeks ago.

Comment on lines 22 to 23
#include <map>
#include <string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you removed the gSharedLibs line that was forcing these includes, so perhaps remove these includes too?

@klendathu2k
Copy link
Contributor Author

They are related, and I think this PR may be needed to resolve the CI issues with #751.

Looks like you're doing the same thing that you proposed in PR #751 , but that was for a Cling-compiled macro, while this will be for cons-compiled code. I'm not aware of a reason to oppose, other than Dmitri's comments in PR #751 a couple weeks ago.

@plexoos
Copy link
Member

plexoos commented Jun 18, 2025

@klendathu2k Do you use a specific test command to verify the change? If so, could you share it?

@klendathu2k
Copy link
Contributor Author

klendathu2k commented Jun 18, 2025 via email

@plexoos
Copy link
Member

plexoos commented Jun 18, 2025

Thanks! Which commands should I run to reproduce the issue?

@plexoos
Copy link
Member

plexoos commented Jun 20, 2025

... to avoid problems when we mix TSystem::Load with #prama cling load

I cannot reproduce the issue. I don't see any problem running the following commands:

[cvmfswrite01] ~/> setup 64b
[cvmfswrite01] ~/> setenv GROUP_DIR /star/u/jeromel/work/STAR/group
[cvmfswrite01] ~/> starver SL24x config/v0.3.0-rhel7-root6.24.06
[cvmfswrite01] ~/> which root4star
/star/nfs4/AFS/star/packages/SL24x/.sl73_x8664_gcc485/bin/root4star
[cvmfswrite01] ~/> root4star
   ------------------------------------------------------------------
  | Welcome to ROOT 6.24/06                        https://root.cern |
  | (c) 1995-2021, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for linuxx8664gcc on Sep 02 2021, 14:20:23                 |
  | From tags/v6-24-06@v6-24-06                                      |
  | With g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)                 |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'       |
   ------------------------------------------------------------------

 *** Start at Date : Fri Jun 20 10:11:44 2025
root [0] 

@genevb
Copy link
Contributor

genevb commented Jun 25, 2025 via email

@plexoos
Copy link
Member

plexoos commented Jun 25, 2025

@ plexoos , to be clear, you should use the standard NFSv4 GROUP_DIR to experience the issue: /star/nfs4/AFS/star/group

Thanks for pointing that out, Gene. It wasn’t clear to me from the previous messages that GROUP_DIR specifically needed to be set to that path.

That said, since I’ve already tested it using the fixed setup scripts and couldn’t reproduce the issue, it makes me wonder: Is there really a need to modify the code, if adjusting the environment resolves it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants