Embedding pp510 setup #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akanugan
commented
Sep 8, 2025
akanugan
commented
- This PR is from Xianglei to the tpc calibration for the pp510 embedding setup.
- Has to be back ported to SL20c
Member
|
Is there a QA presentation for this calibration set? I think we have practiced attaching slides to the corresponding PRs. |
Contributor
Author
@zhux97 said that he will find the data/MC comparison for pp510 dataset done with this file, which would take some time (~ 2 weeks) |
iraklic
approved these changes
Sep 15, 2025
Member
iraklic
left a comment
iraklic
left a comment
There was a problem hiding this comment.
Since this is not really a change but a new calib file with a unique timestamp I approve this not to stop anybody from using this calib, but I hope the promised QA presentation will be atteched.
akanugan
added a commit
to akanugan/star-sw
that referenced
this pull request
Sep 24, 2025
- This PR is from Xianglei to the tpc calibration for the pp510 embedding setup. - Has to be back ported to SL20c Co-authored-by: Ankush Kanuganti <[email protected]>
plexoos
pushed a commit
that referenced
this pull request
Oct 1, 2025
- This PR #767 is for tpc calibration used in embedding jobs for latest pp510 setup by Xianglei - Needs a new tag once merged. - Will attach the QA to the main PR in couple of weeks. --------- Co-authored-by: Ankush Kanuganti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.