ci: add stable ci-success gate for branch protection - #17
Merged
Conversation
The branch protection required check was named `test`, but the matrix job reports as `test (macos-latest, 3.12)`, so the required context never matched and every PR was unmergeable without admin. Add a lightweight `ci-success` aggregator job (needs: test, lint) with a stable name for branch protection to require, independent of the matrix. Drop the trigger-level paths-ignore so the gate always reports (a required check that is skipped for docs-only changes would otherwise block those PRs). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Branch protection on
mainrequired a status check namedtest, but the matrix job actually reports astest (macos-latest, 3.12). The names never matched, so the required check was never satisfied and every PR was unmergeable without admin (e.g. #16 had to be admin-merged despite green CI).Fix
ci-successaggregator job (needs: [test, lint], ubuntu, runs in seconds) with a stable name that branch protection can require, independent of the test matrix / Python versions.paths-ignore. A required check that gets skipped for docs-only changes would itself block those PRs; running the fast gate unconditionally avoids that footgun.After this merges, branch protection is updated to require
ci-successinstead oftest, and normal PRs merge without admin.Note
This PR runs the new workflow, so it produces the
ci-successcheck itself — merging it normally validates the fix end-to-end.🤖 Generated with Claude Code