Skip to content

Conversation

@eytan-starkware
Copy link
Contributor

@eytan-starkware eytan-starkware commented Dec 2, 2025

TL;DR

Add tracing helper macros and tracing to the lowering optimizations module to help with debugging.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

eytan-starkware commented Dec 2, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eytan-starkware eytan-starkware marked this pull request as ready for review December 2, 2025 12:13
@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-test-utils/src/parse_test_file.rs line 105 at r1 (raw file):

        let mut tag_strings = vec![TAG_PREFIX.to_string() + &test_name];
        for (tag, content) in test.attributes {
            if tag != "test_name" {

how is this related to the logging?

Code quote:

if tag != "test_name"

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyalesokhin-starkware reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @eytan-starkware, @orizi, and @TomerStarkware)


crates/cairo-lang-test-utils/src/parse_test_file.rs line 104 at r1 (raw file):

    for (test_name, test) in tests {
        let mut tag_strings = vec![TAG_PREFIX.to_string() + &test_name];
        for (tag, content) in test.attributes {

were the attributes empty before?

Code quote:

test.attributes

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 2 of 5 files at r1, all commit messages.
Reviewable status: 2 of 5 files reviewed, 3 unresolved discussions (waiting on @eytan-starkware and @TomerStarkware)


crates/cairo-lang-lowering/Cargo.toml line 34 at r1 (raw file):

[dev-dependencies]

Suggestion:

tracing = { workspace = true, features = ["log"] }

[dev-dependencies]

@eytan-starkware eytan-starkware deleted the eytan_graphite/_debug__adding_debug_info branch December 2, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants