Added deprecation for AccountContract trait. #8863
Open
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
force-pushed
the
orizi/12-04-added_deprecation_for_accountcontract_trait
branch
from
11d73bb to
a38dcdb
Compare
liorgold2
reviewed
Dec 4, 2025
Collaborator
liorgold2
left a comment
liorgold2
left a comment
There was a problem hiding this comment.
@liorgold2 reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/starknet.cairo line 107 at r1 (raw file):
interface, formalized in SNIP-6. Users should migrate to defining a contract interface trait (e.g., #[starknet::interface] trait IAccount) that includes the mandatory SNIP-6 entry points: `__validate__`, `__execute__`, `__validate_declare__`, and
Are all of them mandatory by SNIP-6?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.