-
Notifications
You must be signed in to change notification settings - Fork 699
Add option to extract functions debug info to configs #8969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @piotmag769)
crates/cairo-lang-compiler/src/lib.rs line 58 at r1 (raw file):
/// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to /// [Annotations] in [DebugInfo] in the compiled tests.
Suggestion:
/// Adds a mapping used by
/// [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
/// [Annotations] in [DebugInfo] in the compiled tests.crates/cairo-lang-test-plugin/src/lib.rs line 77 at r1 (raw file):
/// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to /// [Annotations] in [DebugInfo] in the compiled tests.
Suggestion:
/// Adds a mapping used by
/// [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
/// [Annotations] in [DebugInfo] in the compiled tests.b533fcb to
ae1927b
Compare
a6c1e22 to
adc1109
Compare
piotmag769
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piotmag769 reviewed 4 of 6 files at r1.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @orizi)
crates/cairo-lang-compiler/src/lib.rs line 58 at r1 (raw file):
/// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to /// [Annotations] in [DebugInfo] in the compiled tests.
Done.
crates/cairo-lang-test-plugin/src/lib.rs line 77 at r1 (raw file):
/// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to /// [Annotations] in [DebugInfo] in the compiled tests.
Done.
adc1109 to
31a8a67
Compare
commit-id:c5d50d84
31a8a67 to
7388237
Compare
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @piotmag769)
No description provided.