Skip to content

Conversation

@piotmag769
Copy link
Collaborator

@piotmag769 piotmag769 commented Dec 8, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @piotmag769)


crates/cairo-lang-compiler/src/lib.rs line 58 at r1 (raw file):

    /// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
    /// [Annotations] in [DebugInfo] in the compiled tests.

Suggestion:

    /// Adds a mapping used by
    /// [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
    /// [Annotations] in [DebugInfo] in the compiled tests.

crates/cairo-lang-test-plugin/src/lib.rs line 77 at r1 (raw file):

    /// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
    /// [Annotations] in [DebugInfo] in the compiled tests.

Suggestion:

    /// Adds a mapping used by
    /// [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
    /// [Annotations] in [DebugInfo] in the compiled tests.

@piotmag769 piotmag769 force-pushed the spr/main/c5d50d84 branch 2 times, most recently from a6c1e22 to adc1109 Compare December 10, 2025 00:55
@piotmag769 piotmag769 changed the base branch from spr/main/0499d906 to main December 10, 2025 00:55
Copy link
Collaborator Author

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piotmag769 reviewed 4 of 6 files at r1.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @orizi)


crates/cairo-lang-compiler/src/lib.rs line 58 at r1 (raw file):

    /// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
    /// [Annotations] in [DebugInfo] in the compiled tests.

Done.


crates/cairo-lang-test-plugin/src/lib.rs line 77 at r1 (raw file):

    /// Adds a mapping used by [cairo-debugger](https://github.com/software-mansion-labs/cairo-debugger) to
    /// [Annotations] in [DebugInfo] in the compiled tests.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @piotmag769)

@piotmag769 piotmag769 added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 778ea44 Dec 10, 2025
105 checks passed
@piotmag769 piotmag769 deleted the spr/main/c5d50d84 branch December 10, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants