Skip to content

Conversation

@FroyaTheHen
Copy link
Collaborator

@FroyaTheHen FroyaTheHen commented Dec 9, 2025

partially closes software-mansion/scarb#2840

This is a Scarb task but it turned out that LS also faces the problem where in some cases the custom logic needs to implemented for building an item signature.
This PR aims at:

  • exposing some compiler logic so the same methods can be used by Scarb and LS,
  • brings some minor redability improvements

@reviewable-StarkWare
Copy link

This change is Reviewable

@FroyaTheHen FroyaTheHen requested review from Draggu and orizi December 9, 2025 04:23
@FroyaTheHen FroyaTheHen self-assigned this Dec 9, 2025
@FroyaTheHen FroyaTheHen marked this pull request as ready for review December 9, 2025 04:24
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Draggu and @FroyaTheHen)


crates/cairo-lang-doc/src/signature_data.rs line 35 at r1 (raw file):

/// A helper struct gathering documentable item's signature data.
pub struct DocumentableItemSignatureData<'db> {
    pub item_id: DocumentableItemId<'db>,

doc all field now, since pub.


crates/cairo-lang-doc/src/signature_data.rs line 88 at r1 (raw file):

implement_signature_data_retriever!(ImplConstantDefId<'db>, get_impl_constant_signature_data);

/// A utility function retrieves [`ModuleItemInfo`] for [`ModuleItemId`].

*that retrieves

Copy link
Collaborator Author

@FroyaTheHen FroyaTheHen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Draggu and @orizi)


crates/cairo-lang-doc/src/signature_data.rs line 35 at r1 (raw file):

Previously, orizi wrote…

doc all field now, since pub.

Done.


crates/cairo-lang-doc/src/signature_data.rs line 88 at r1 (raw file):

Previously, orizi wrote…

*that retrieves

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Draggu)

@FroyaTheHen FroyaTheHen added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit e9af66e Dec 11, 2025
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix struct signature

4 participants