(refactor): collecting segments for full_path before formatting to string #8999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
orizi
approved these changes
Dec 9, 2025
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase and @TomerStarkware)
TomerStarkware
approved these changes
Dec 10, 2025
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the path representation for language elements to use path segments instead of string concatenation, providing a more structured approach to handling paths.
This resulted in tests getting a fuller path (including name of trait of impl which was missing before)