Improved var-based inference diagnostics locations.

[orizi]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

• Improved var-based inference diagnostics locations. #9006 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[eytan-starkware]

@eytan-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/inference.rs line 899 at r1 (raw file):

            return Ok(());
        };
        Err((self.set_error(err), self.stable_ptrs.get(&var).copied()))

Shouldt finalize_without_reporting also use set_error_on_var?

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @TomerStarkware)

---

crates/cairo-lang-semantic/src/expr/inference.rs line 899 at r1 (raw file):

Previously, eytan-starkware wrote…

Shouldt finalize_without_reporting also use set_error_on_var?

changed finalize\_without\_reporting and remove solve_ex to all use this new mechanism.

[TomerStarkware]

@TomerStarkware reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware)

[eytan-starkware]

@eytan-starkware reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)