Skip to content

Conversation

@Fibonacci747
Copy link
Contributor

The split_structs optimization module was importing std::vec but never using the vec module directly (no vec::Vec, vec::IntoIter, etc.). Vec and the vec! macro come from the standard prelude in this workspace (Rust 2024 edition, no no_std or no_implicit_prelude), so this import was effectively dead code. Removing it cleans up the imports without changing behavior or semantics of the optimization.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Fibonacci747)

@orizi orizi enabled auto-merge December 10, 2025 14:26
@orizi orizi added this pull request to the merge queue Dec 10, 2025
Merged via the queue into starkware-libs:main with commit 144c7b1 Dec 10, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants