starknet_transaction_prover: finalize test recordings only after assertions pass (#14212)

Author: AvivYossef-starkware

crates/starknet_transaction_prover/src/proving/virtual_snos_prover_test.rs

@@ -73,9 +73,6 @@ async fn test_prove_transfer_transaction() {
     // Run the full prover pipeline: OS execution → proof generation.
     let result = prover.prove_transaction(BlockId::Latest, rpc_tx).await;
 
-    // Finalize recording before asserting so records are saved even on failure.
-    test_mode.finalize();
-
     // Verify execution and proving succeeded.
     let output = result.expect("prove_transaction should succeed");
 
@@ -86,4 +83,6 @@ async fn test_prove_transfer_transaction() {
         .await
         .expect("proof verification task panicked")
         .expect("proof verification should succeed");
+
+    test_mode.finalize();
 }

crates/starknet_transaction_prover/src/running/virtual_block_executor_test.rs

@@ -219,8 +219,6 @@ async fn test_execute_with_prefetch() {
     .await
     .unwrap();
 
-    test_mode.finalize();
-
     let result = result.expect("execute with prefetch should succeed");
 
     assert_eq!(result.execution_outputs.len(), 1, "Should have exactly one execution output");
@@ -231,6 +229,8 @@ async fn test_execute_with_prefetch() {
         "Transaction should not revert. Error: {:?}",
         execution_info.revert_error
     );
+
+    test_mode.finalize();
 }
 
 /// Verifies that a transaction is rejected when the bouncer config has tight capacity limits.