Skip to content

starknet_transaction_prover: add committer utils unit tests#14046

Open
avi-starkware wants to merge 1 commit into
main-v0.14.3from
avi/privacy/committer-utils-tests-v2
Open

starknet_transaction_prover: add committer utils unit tests#14046
avi-starkware wants to merge 1 commit into
main-v0.14.3from
avi/privacy/committer-utils-tests-v2

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

Covers state_maps_to_committer_state_diff (empty / nonces / storage /
compiled class hashes) and validate_virtual_os_state_diff (valid storage,
valid nonce, and rejection of storage deletion / contract deployment /
contract declaration).

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@avi-starkware avi-starkware marked this pull request as ready for review May 17, 2026 15:42
@cursor
Copy link
Copy Markdown

cursor Bot commented May 17, 2026

PR Summary

Low Risk
Test-only changes with no production logic modified.

Overview
Adds committer_utils_test and wires it into the running test module.

New unit tests cover state_maps_to_committer_state_diff (empty maps and preservation of nonces, storage, and compiled class hashes) and validate_virtual_os_state_diff (accepts empty/nonzero storage/nonce updates; rejects storage deletion, contract deployments, and contract declarations with expected InvalidStateDiff messages).

Reviewed by Cursor Bugbot for commit 257e70a. Bugbot is set up for automated code reviews on this repo. Configure here.

Covers state_maps_to_committer_state_diff (empty / nonces / storage /
compiled class hashes) and validate_virtual_os_state_diff (valid storage,
valid nonce, and rejection of storage deletion / contract deployment /
contract declaration).
@avi-starkware avi-starkware changed the base branch from main to graphite-base/14046 May 31, 2026 10:38
@avi-starkware avi-starkware force-pushed the avi/privacy/committer-utils-tests-v2 branch from 7a2f45c to 257e70a Compare May 31, 2026 10:39
@avi-starkware avi-starkware changed the base branch from graphite-base/14046 to main-v0.14.3 May 31, 2026 10:39
@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants