Skip to content

deployment: wait for node healthcheck before starting the simulator#14225

Open
sirandreww-starkware wants to merge 1 commit into
05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stackfrom
05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator
Open

deployment: wait for node healthcheck before starting the simulator#14225
sirandreww-starkware wants to merge 1 commit into
05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stackfrom
05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 27, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Local docker-compose orchestration only; no production runtime, auth, or application logic changes.

Overview
The local monitoring docker-compose stack now treats sequencer nodes as healthy only after the HTTP gateway on port 8081 accepts connections, using a bash /dev/tcp probe (no curl in the image).

sequencer_simulator no longer starts as soon as sequencer-node-0 is merely running; it waits until that node reports healthy, avoiding races where the simulator hits the gateway before it is bound.

The healthcheck is defined on the shared x-sequencer-node anchor, so every node service inherits the same readiness semantics.

Reviewed by Cursor Bugbot for commit 9a67ab6. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from 0d4dc26 to 0d4299b Compare May 28, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch from 261a8e1 to 0a0acfb Compare May 28, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from 0d4299b to adf97ec Compare May 28, 2026 09:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch from 0a0acfb to 0c86666 Compare May 28, 2026 09:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from adf97ec to 11e78ad Compare May 28, 2026 11:47
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch 2 times, most recently from 8fb59bc to e8ad99b Compare June 1, 2026 13:33
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from 11e78ad to be13a5c Compare June 1, 2026 13:33
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


deployments/monitoring/local/docker-compose.yml line 30 at r1 (raw file):

  # for it instead of racing the gateway bind. Uses bash /dev/tcp since the image has no curl.
  healthcheck:
    test: ["CMD", "bash", "-c", "</dev/tcp/localhost/8081"]

Is there a way to get the 8081 here from the node config (or get the node config from this line) so they won't drift?

@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_add_n_nodes_flag_to_run_multiple_nodes_in_local_monitoring_stack branch from e8ad99b to f6051eb Compare June 1, 2026 14:21
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-deployment_wait_for_node_healthcheck_before_starting_the_simulator branch from be13a5c to 9a67ab6 Compare June 1, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants