Skip to content

apollo_rpc: delete client_transaction conversion impls#14271

Open
ShahakShama wants to merge 1 commit into
shahak/erase_writer_03_write_api_errorfrom
shahak/erase_writer_04_client_transaction_conversions
Open

apollo_rpc: delete client_transaction conversion impls#14271
ShahakShama wants to merge 1 commit into
shahak/erase_writer_03_write_api_errorfrom
shahak/erase_writer_04_client_transaction_conversions

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

Remove all From/TryFrom impls converting RPC transaction types to
apollo_starknet_client::writer::objects::transaction types. These were
only used by the add_*_transaction handlers removed in the previous PR.

Also removes TypedInvokeTransaction and TypedDeployAccountTransaction,
which were only needed as input types for the deleted handlers.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

Remove all From/TryFrom impls converting RPC transaction types to
apollo_starknet_client::writer::objects::transaction types. These were
only used by the add_*_transaction handlers removed in the previous PR.

Also removes TypedInvokeTransaction and TypedDeployAccountTransaction,
which were only needed as input types for the deleted handlers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ShahakShama ShahakShama requested a review from dan-starkware June 1, 2026 07:39
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 1, 2026

PR Summary

Low Risk
Pure deletion of unused conversion code with no remaining references in apollo_rpc; no runtime behavior change expected.

Overview
Removes dead conversion code between RPC v0.8 transaction types and apollo_starknet_client::writer::objects::transaction, left over after dropping the add_*_transaction RPC handlers.

In broadcasted_transaction.rs, deletes TryFrom<BroadcastedDeclareTransaction> for declare v1/v2/v3 (including Sierra compression and client ContractClass mapping) and drops unused imports (client_transaction, compress_and_encode, StorageSerdeError).

In transaction.rs, removes all From impls mapping invoke/deploy-account RPC structs and enums into the writer client types, and removes TypedInvokeTransaction and TypedDeployAccountTransaction (typed JSON wrappers that only served those handlers).

Reviewed by Cursor Bugbot for commit 37fe747. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants