apollo_consensus_orchestrator: test parent proposal commitment binds parent fee_proposal#14285
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
29ba278 to
1de9d15
Compare
PR SummaryLow Risk Overview The test builds a proposal at HEIGHT_1, seeds No production logic changes—test-only coverage for parent fee binding in blob params. Reviewed by Cursor Bugbot for commit e70ef63. Bugbot is set up for automated code reviews on this repo. Configure here. |
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).
crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 778 at r1 (raw file):
deps.cende_ambassador.expect_prepare_blob_for_next_height().times(1).return_once( move |params| { assert_eq!(params.parent_proposal_commitment, Some(expected_parent_commitment));
Check also the proposal commitment
1de9d15 to
764185f
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ShahakShama).
crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 778 at r1 (raw file):
Previously, ShahakShama wrote…
Check also the proposal commitment
Done.
764185f to
8214dc6
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).
…parent fee_proposal
8214dc6 to
e70ef63
Compare

No description provided.