Skip to content

apollo_consensus_orchestrator: test parent proposal commitment binds parent fee_proposal#14285

Merged
sirandreww-starkware merged 1 commit into
main-v0.14.3from
06-01-apollo_consensus_orchestrator_test_parent_proposal_commitment_binds_parent_fee_proposal
Jun 3, 2026
Merged

apollo_consensus_orchestrator: test parent proposal commitment binds parent fee_proposal#14285
sirandreww-starkware merged 1 commit into
main-v0.14.3from
06-01-apollo_consensus_orchestrator_test_parent_proposal_commitment_binds_parent_fee_proposal

Conversation

@sirandreww-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware force-pushed the 06-01-apollo_consensus_orchestrator_test_parent_proposal_commitment_binds_parent_fee_proposal branch 2 times, most recently from 29ba278 to 1de9d15 Compare June 1, 2026 12:16
@sirandreww-starkware sirandreww-starkware self-assigned this Jun 1, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review June 1, 2026 12:23
@cursor

cursor Bot commented Jun 1, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only change with no runtime behavior modifications.

Overview
Adds an integration test in sequencer_consensus_context_test.rs that locks in how Cende blob preparation wires parent_proposal_commitment after consensus decides at height 1.

The test builds a proposal at HEIGHT_1, seeds fee_proposals_window at HEIGHT_0 with a parent fee distinct from the current block’s default, simulates decision_reached with batcher CentralObjects carrying a parent partial block hash, and asserts prepare_blob_for_next_height receives parent_proposal_commitment equal to proposal_commitment_from(PARTIAL_BLOCK_HASH, Some(PARENT_FEE_PROPOSAL)) (V0_14_3-style binding of parent fee_proposal_fri), alongside the expected current proposal_commitment.

No production logic changes—test-only coverage for parent fee binding in blob params.

Reviewed by Cursor Bugbot for commit e70ef63. Bugbot is set up for automated code reviews on this repo. Configure here.

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 778 at r1 (raw file):

    deps.cende_ambassador.expect_prepare_blob_for_next_height().times(1).return_once(
        move |params| {
            assert_eq!(params.parent_proposal_commitment, Some(expected_parent_commitment));

Check also the proposal commitment

@sirandreww-starkware sirandreww-starkware force-pushed the 06-01-apollo_consensus_orchestrator_test_parent_proposal_commitment_binds_parent_fee_proposal branch from 1de9d15 to 764185f Compare June 3, 2026 05:43

@sirandreww-starkware sirandreww-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 778 at r1 (raw file):

Previously, ShahakShama wrote…

Check also the proposal commitment

Done.

@sirandreww-starkware sirandreww-starkware force-pushed the 06-01-apollo_consensus_orchestrator_test_parent_proposal_commitment_binds_parent_fee_proposal branch from 764185f to 8214dc6 Compare June 3, 2026 07:36

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 06-01-apollo_consensus_orchestrator_test_parent_proposal_commitment_binds_parent_fee_proposal branch from 8214dc6 to e70ef63 Compare June 3, 2026 15:45
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main-v0.14.3 with commit 1fa151a Jun 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants