idan/main/fix sequencer selector label bug#14290
Closed
idan-starkware wants to merge 21 commits into
Closed
Conversation
Contributor
idan-starkware
commented
Jun 1, 2026
idan-starkware
commented
- No conflicts in main-v0.14.3 -> main merge, this commit is for any change needed to pass the CI.
- starknet_committer: add patricia paths forest reader/writer traits (starknet_committer: add patricia paths forest reader/writer traits #13995)
- starknet_patricia: change test util random u256 (starknet_patricia: change test util random u256 #14193)
- apollo_committer_types: add patricia proofs request and response types (apollo_committer_types: add patricia proofs request and response types #13996)
- release: add v0.14.4 SN version to enum (release: add v0.14.4 SN version to enum #14237)
- release: upgrade rand crate version (release: upgrade rand crate version #14194)
- starknet_committer: split commit_block into read and compute phases (starknet_committer: split commit_block into read and compute phases #14213)
- starknet_committer: read and write patricia paths to index db (starknet_committer: read and write patricia paths to index db #13998)
- release: upgrade rand to 0.10 (release: upgrade rand to 0.10 #14250)
- starknet_committer: derive skeleton updates from actual updates (starknet_committer: derive skeleton updates from actual updates #14214)
- starknet_os: import random EC point logic (starknet_os: import random EC point logic #14195)
- scripts: drop the llvm.sh SHA pin in install_llvm19.sh (scripts: drop the llvm.sh SHA pin in install_llvm19.sh #14265)
- starknet_committer: name TrieReadTask lifetimes and document them (starknet_committer: name TrieReadTask lifetimes and document them #14239)
- starknet_committer: extract commit plan to commit_or_load (starknet_committer: extract commit plan to commit_or_load #13999)
- starknet_committer: extract metadata construction to a function (starknet_committer: extract metadata construction to a function #14000)
- apollo_integration_tests: fix flaky test due to metric registration race (apollo_integration_tests: fix flaky test due to metric registration race #14253)
- starknet_committer: underlying logic of the new read witnesses and commit endpoint (starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001)
- starknet_os: os resources test - create fixed deployable account (starknet_os: os resources test - create fixed deployable account #14173)
- starknet_os_flow_tests: helper function to declare explicit classes (starknet_os_flow_tests: helper function to declare explicit classes #14257)
- fix: sequencer selector labels
…ange needed to pass the CI.
…-into-main-1779955702 Merge main-v0.14.3 into main
Signed-off-by: Dori Medini <dori@starkware.co>
…14213) Extract read_original_forest (IO-bound) and compute_updated_forest (CPU-bound) so the DB is free for parallel reads during computation. Decouple the storage/classes update lifetimes from the original forest's lifetime in the read path, since the forest only borrows the sorted indices; this lets the compute phase take ownership of the update maps. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
read_original_forest now takes &Input. The skeleton updates fed to UpdatedSkeletonForest are derived from the already-computed actual updates via a generic skeleton_trie_updates (pure value mapping), instead of re-walking the state diff. Adds From<_> for SkeletonLeaf impls for the leaf value types to back the generic bound. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The pin only authenticated the install script's bytes, not the LLVM packages it installs. Those are verified by the apt GPG key that llvm.sh fetches over TLS at runtime (unpinned), so the real trust root is already "TLS-authenticated apt.llvm.org" -- the same trust we place in the apt packages themselves. Pinning the script while leaving that key fetch unpinned is a half-measure: a network/host compromise of apt.llvm.org can swap the key and serve malicious packages regardless of the script hash. Given we trust apt.llvm.org over TLS (consistent with the rest of our apt usage), drop the pin and its change-control comments. This also removes the recurring CI break + hash-bump chore on every benign upstream edit to llvm.sh, and aligns this path with the replay Dockerfile, which already fetches llvm.sh unpinned. The download keeps strict TLS (--proto =https --tlsv1.2 --fail). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…4239) The struct now uses 'indices / 'updates / 'storage instead of 'a / 'u / 's, and the doc comment explains why two non-storage lifetimes are needed: unifying them would make the returned OriginalSkeletonForest appear to borrow the storage update maps too, preventing the compute phase from moving those maps by value. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ace (#14253) Fix race condition where tests query metrics before StateSyncRunner registers them: - sequencer_num_accepted_txs: Return 0 for MetricNotFound errors (safe since it's used in polling loops), panic on other unexpected errors - assert_no_reverted_txs: Add retry loop until the metric is registered, avoiding false positives https://claude.ai/code/session_014UmiFHenEiE4vNnh8qbGkZ Co-authored-by: Claude <noreply@anthropic.com>
PR SummaryHigh Risk Overview Release CI expands apollo_storage_os_input to Reviewed by Cursor Bugbot for commit 59a012a. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.