starknet_os_flow_tests: measure OS linear syscall resources with many…#14461
Conversation
PR SummaryLow Risk Overview The Cairo Reviewed by Cursor Bugbot for commit a9d1d3f. Bugbot is set up for automated code reviews on this repo. Configure here. |
a281946 to
331e42d
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 54 at r1 (raw file):
let mut large_input: Array<felt252> = array![LARGE_INPUT_LENGTH.into()]; for _ in 0..LARGE_INPUT_LENGTH { large_input.append(1);
It's 0 in your documentation. Fix one of the
Code quote:
large_input.append(1);… elements Signed-off-by: Dori Medini <dori@starkware.co>
331e42d to
a9d1d3f
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on Yoni-Starkware).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
… elements