blockifier,apollo_batcher: trim OS initial reads to the accessed-key set#14595
blockifier,apollo_batcher: trim OS initial reads to the accessed-key set#14595yoavGrs wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
PR SummaryMedium Risk Overview Adds A small comment in apollo_committer documents the Reviewed by Cursor Bugbot for commit d865f09. Bugbot is set up for automated code reviews on this repo. Configure here. |
baca9cc to
c0904c6
Compare
f4a9965 to
94b61d9
Compare
c0904c6 to
28dc2c0
Compare
94b61d9 to
4cc1677
Compare
28dc2c0 to
840c728
Compare
4cc1677 to
5410333
Compare
|
Suggestion from Claude Code: Could we add direct unit tests in
|
840c728 to
41b34a9
Compare
41b34a9 to
f334583
Compare
5410333 to
9d4eabf
Compare
9d4eabf to
d57b5a2
Compare
f334583 to
c7678fc
Compare
Drop initial-reads entries whose keys are not in AccessedKeys (e.g. storage cells read only by a reverted transaction). The OS replays from the read values of the keys it accesses and needs nothing beyond that set, so the extra entries would only bloat the cende blob. Validated by the OS flow tests (113 passing), including all reverted-tx cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d57b5a2 to
9863839
Compare
c7678fc to
d865f09
Compare

Drop initial-reads entries whose keys are not in AccessedKeys (e.g. storage cells read only by a reverted transaction). The OS replays from the read values of the keys it accesses and needs nothing beyond that set, so the extra entries would only bloat the cende blob. Validated by the OS flow tests (113 passing), including all reverted-tx cases.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com