Skip to content

Conversation

@MohammadNassar1
Copy link
Collaborator

@MohammadNassar1 MohammadNassar1 commented Sep 30, 2025

This change is Reviewable

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ishay-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)


README.md line 4 at r2 (raw file):

<div align="center">

<picture>

add these files to the repo - the logo is missing

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @MohammadNassar1)


docs/spec.md line 1 at r2 (raw file):

Contract

spec md file is looking bad - plz fix it

@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/add-audit-report branch from 40482ab to 349ca1c Compare October 8, 2025 07:59
Copy link
Collaborator Author

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 7 files reviewed, 2 unresolved discussions (waiting on @ishay-starkware)


README.md line 4 at r2 (raw file):

Previously, ishay-starkware wrote…

add these files to the repo - the logo is missing

Done.


docs/spec.md line 1 at r2 (raw file):

Previously, ishay-starkware wrote…

spec md file is looking bad - plz fix it

I regenerated it.

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishay-starkware reviewed 3 of 4 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@MohammadNassar1 MohammadNassar1 merged commit 7abff82 into main Oct 8, 2025
3 checks passed
@MohammadNassar1 MohammadNassar1 deleted the mohammad/add-audit-report branch October 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants