feat(payments): implement setter and getter methods

[MohammadNassar1]

This change is 

[ishay-starkware]

you can also separate each getter and setter to a different PR.
also - no tests

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)

---

src/payments.cairo line 138 at r1 (raw file):

                self.fulfillment.write(order_hash, order.amount_a.abs());
            }
        }

separate this to a different PR - this pr is only for getters and setters as the title suggest.
you can also add the Order struct in a different PR and then you won't need the TODO

Code quote:

        fn cancel_orders(ref self: ContractState, orders: Span<Order>) {
            let caller = get_caller_address();

            for order in orders {
                assert(*order.address == caller, INVALID_CALLER_ADDRESS);

                // TODO(Mohammad): Replace with actual hash computation logic.
                let order_hash: HashType = Default::default();
                self.fulfillment.write(order_hash, order.amount_a.abs());
            }
        }

[ishay-starkware]

src/payments.cairo line 170 at r1 (raw file):

            let ordered_amount = order.amount_a.abs();
            ordered_amount == fulfilled_amount
        }

also in a different pr after you have the hash.

Code quote:

        fn is_order_fulfilled(self: @ContractState, order: Order) -> bool {
            // TODO(Mohammad): Replace with actual hash computation logic.
            let order_hash: HashType = Default::default();
            let fulfilled_amount = self.fulfillment.read(order_hash);
            let ordered_amount = order.amount_a.abs();
            ordered_amount == fulfilled_amount
        }

[ishay-starkware]

src/payments.cairo line 146 at r1 (raw file):

            assert(fee <= MAX_BASIS_POINTS.into(), INVALID_HIGH_FEE);
            self.fee.write(fee);

do this in a private fn called _set_fee and then call it from the constructor as well

Code quote:

            assert(fee <= MAX_BASIS_POINTS.into(), INVALID_HIGH_FEE);
            self.fee.write(fee);

[ishay-starkware]

src/payments.cairo line 152 at r1 (raw file):

            assert(recipient.is_non_zero(), INVALID_ZERO_ADDRESS);
            self.fee_recipient.write(recipient);

same

Code quote:

            assert(recipient.is_non_zero(), INVALID_ZERO_ADDRESS);
            self.fee_recipient.write(recipient);

[ishay-starkware]

src/payments.cairo line 114 at r1 (raw file):

        ) {}

        fn register_token(ref self: ContractState, token: ContractAddress) {

you should probably have a is_token_registered fn as well

[ishay-starkware]

src/payments.cairo line 118 at r1 (raw file):

            assert(token.is_non_zero(), INVALID_ZERO_ADDRESS);
            assert(!self.tokens.read(token), TOKEN_ALREADY_REGISTERED);

here call the is_token_registered

[ishay-starkware]

src/payments.cairo line 114 at r1 (raw file):

        ) {}

        fn register_token(ref self: ContractState, token: ContractAddress) {

register_token and remove_token should be in a separate PR

[MohammadNassar1]

Reviewable status: 1 of 3 files reviewed, 7 unresolved discussions (waiting on @ishay-starkware)

---

src/payments.cairo line 114 at r1 (raw file):

Previously, ishay-starkware wrote…

you should probably have a is_token_registered fn as well

Done.
here

---

src/payments.cairo line 114 at r1 (raw file):

Previously, ishay-starkware wrote…

register_token and remove_token should be in a separate PR

Done.
here

---

src/payments.cairo line 118 at r1 (raw file):

Previously, ishay-starkware wrote…

here call the is_token_registered

Done.
here

[MohammadNassar1]

Reviewable status: 1 of 3 files reviewed, 7 unresolved discussions (waiting on @ishay-starkware and @MohammadNassar1)

---

src/payments.cairo line 138 at r1 (raw file):

Previously, ishay-starkware wrote…

separate this to a different PR - this pr is only for getters and setters as the title suggest.
you can also add the Order struct in a different PR and then you won't need the TODO

Moved to another PR.
I'll keep it for now with the todo, as I got stuck with the order hash.

---

src/payments.cairo line 146 at r1 (raw file):

Previously, ishay-starkware wrote…

do this in a private fn called _set_fee and then call it from the constructor as well

Done.

---

src/payments.cairo line 152 at r1 (raw file):

Previously, ishay-starkware wrote…

same

Done.

---

src/payments.cairo line 170 at r1 (raw file):

Previously, ishay-starkware wrote…

also in a different pr after you have the hash.

Moved to another PR.
I'll keep it for now with the todo, as I got stuck with the order hash.

[MohammadNassar1]

done

Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @ishay-starkware and @MohammadNassar1)

[ishay-starkware]

src/payments.cairo line 159 at r2 (raw file):

    pub impl ImplInternalPayments of InternalPaymentsTrait {
        fn _set_fee(ref self: ContractState, fee: u128) {
            assert(fee <= MAX_BASIS_POINTS.into(), INVALID_HIGH_FEE);

i assume there should be some max fee as setting the fee to MAX_BASIS_POINTS doesn't make much sense

[ishay-starkware]

Reviewed 2 of 4 files at r2, all commit messages.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @MohammadNassar1)

---

src/errors.cairo line 1 at r2 (raw file):

pub const INVALID_CALLER_ADDRESS: felt252 = 'INVALID_CALLER_ADDRESS';

remove

Code quote:

ub const INVALID_CALLER_ADDRESS: felt252 = 'INVALID_CALLER_ADDRESS';

[MohammadNassar1]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @ishay-starkware and @MohammadNassar1)

---

src/errors.cairo line 1 at r2 (raw file):

Previously, ishay-starkware wrote…

remove

Done.

---

src/payments.cairo line 159 at r2 (raw file):

Previously, ishay-starkware wrote…

i assume there should be some max fee as setting the fee to MAX_BASIS_POINTS doesn't make much sense

Done.

[ishay-starkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)