Skip to content

Conversation

@MohammadNassar1
Copy link
Collaborator

@MohammadNassar1 MohammadNassar1 commented Aug 3, 2025

This change is Reviewable

@ishay-starkware
Copy link
Collaborator

src/payments.cairo line 109 at r1 (raw file):

            self.roles.only_app_governor();

            assert(self.is_token_registered(token), TOKEN_DOES_NOT_EXIST);

TOKEN_NOT_REGISTERED

Code quote:

TOKEN_DOES_NOT_EXIST

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)

@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/payments/impl-token-abis branch from a489ac5 to ae2fdea Compare August 3, 2025 11:13
Copy link
Collaborator Author

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ishay-starkware)


src/payments.cairo line 109 at r1 (raw file):

Previously, ishay-starkware wrote…

TOKEN_NOT_REGISTERED

Done.

Copy link
Collaborator

@ishay-starkware ishay-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@ishay-starkware ishay-starkware merged commit 15686be into main Aug 3, 2025
3 checks passed
@ishay-starkware ishay-starkware deleted the mohammad/payments/impl-token-abis branch August 3, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants