Skip to content

ci(typescript): gate SDK Devnet Test on sdk/contract changes - #929

Merged
ittaysw merged 1 commit into
mainfrom
ittay/dappsdk/ci-devnet-paths-filter
Jul 22, 2026
Merged

ci(typescript): gate SDK Devnet Test on sdk/contract changes#929
ittaysw merged 1 commit into
mainfrom
ittay/dappsdk/ci-devnet-paths-filter

Conversation

@ittaysw

@ittaysw ittaysw commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Skip the Cairo build + devnet e2e on PRs that touch neither the SDK nor the
contracts (e.g. client-only PRs), mirroring the existing paths-filter on the
lint job. The steps no-op and the job still reports success, so a required
check stays satisfied without gating client PRs on the unrelated devnet build.


This change is Reviewable

ittaysw commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TypeScript CI workflow to avoid running the SDK devnet E2E suite (which builds Cairo contracts + runs devnet tests) on PRs that don’t touch the SDK or Cairo/contracts-related files, while still keeping the required CI check reporting success.

Changes:

  • Add a dorny/paths-filter gate to the SDK Devnet Test job based on changes to sdk/**, packages/**, and Scarb files.
  • Condition the devnet job’s expensive setup/build/test steps on the filter output so client-only PRs no-op the job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/typescript-ci.yml

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ittaysw).

Comment thread .github/workflows/typescript-ci.yml
Copilot AI review requested due to automatic review settings July 20, 2026 05:59
@ittaysw
ittaysw force-pushed the ittay/dappsdk/ci-devnet-paths-filter branch from afdcdab to 4642457 Compare July 20, 2026 05:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/typescript-ci.yml
Skip the Cairo build + devnet e2e on PRs that touch neither the SDK nor the
contracts (e.g. client-only PRs), mirroring the existing paths-filter on the
lint job. The steps no-op and the job still reports success, so a required
check stays satisfied without gating client PRs on the unrelated devnet build.
Copilot AI review requested due to automatic review settings July 20, 2026 06:16
@ittaysw
ittaysw force-pushed the ittay/dappsdk/ci-devnet-paths-filter branch from 4642457 to 4c10e4b Compare July 20, 2026 06:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ittaysw).

@ittaysw
ittaysw merged commit e96709b into main Jul 22, 2026
10 of 11 checks passed

ittaysw commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

@ittaysw
ittaysw deleted the ittay/dappsdk/ci-devnet-paths-filter branch July 22, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants