-
Notifications
You must be signed in to change notification settings - Fork 87
Add new transaction statuses #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… in starknet_api_openrpc.json
api/starknet_api_openrpc.json
Outdated
| "enum": ["RECEIVED", "REJECTED", "ACCEPTED_ON_L2", "ACCEPTED_ON_L1"], | ||
| "enum": [ | ||
| "RECEIVED", | ||
| "REJECTED", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this PR keep REJECTED if its removal is mentioned in the pre-release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
Note: transaction status have been renamed from the first commit: |
Add errors for fee too low and underpriced replacement transaction
Seperate message fee estimates for all but estimateMessageFee transac…
…descriptions Docs/update unsigned integer descriptions
Add transactions statuses PRE_CONFIRMED and EXECUTED, to be supported in Starknet v0.14.0