Modify pre_confirmed_block_header
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanusk
reviewed
Jun 17, 2025
| ] | ||
| }, | ||
| "PRE_CONFIRMED_BLOCK_HEADER": { | ||
| "title": "Pending block header", |
Collaborator
There was a problem hiding this comment.
Should this be updated to pre-confirmed block header in the title?
amanusk
reviewed
Jun 17, 2025
| "title": "Pending block header", | ||
| "type": "object", | ||
| "properties": { | ||
| "parent_hash": { |
Collaborator
There was a problem hiding this comment.
Why not keep he parent hash as well?
Contributor
Author
There was a problem hiding this comment.
The feeder-provided pre-confirmed block may be published before there are commitment hashes for the previous block, so cannot contain parent hash. One can say that nodes always fetch the pre-confirmed of latest height they know about + 1, so in particular they would also know the parent hash, but would need more logic in the node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove parent hash and add block number to
pre_confirmed_block_header. The parent hash is removed because a pre-confirmed block may be produced while the thread computing the previous height's commitments hasn't concluded.Checklist:
npm run validate_allnpm run format