feat(starknet_getEvent): add transaction_index and event_index to emitted event context
#343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… emitted event context To make creating unique IDs (like used by Voyager, that combines the block number, the transaction index, and the event index within the transaction) possible without additional JSON-RPC calls, this change adds two new indices to the context of emitted events: - `transaction_index` is the index of the transaction within the block that has emitted the event. - `event_index` is the index of the event within the transaction.
eitanm-starkware
changed the base branch from
release/v0.10.0-rc.0
to
release/v0.10.0-rc.1
eitanm-starkware
merged commit 3c4e87d
into
starkware-libs:release/v0.10.0-rc.1
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To make creating unique IDs (like used by Voyager, that combines the block number, the transaction index, and the event index within the transaction) possible without additional JSON-RPC calls, this change adds two new indices to the context of emitted events:
transaction_indexis the index of the transaction within the block that has emitted the event.event_indexis the index of the event within the transaction.This change also brings us closer to feature parity with the Ethereum JSON-RPC API, where
eth_getLogsreturns both the transaction index and the log index (the index of the event within the block).Checklist:
npm run validate_allnpm run format