Add finalize_constants file.#469
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a771cbe to
b51812e
Compare
e0acf30 to
b3cc405
Compare
ad259de to
7fbe904
Compare
ce66050 to
e8ec356
Compare
e8ec356 to
d36d48e
Compare
gilbens-starkware
left a comment
There was a problem hiding this comment.
@gilbens-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on alon-f and leo-starkware).
crates/circuits/src/finalize_constants.rs line 21 at r1 (raw file):
/// is to make testing easier by choosing a smaller minimum base. // TODO(Leo): remove allow once integrated in the main flow. #[allow(unused)]
Suggestion:
#[expect(unused)]
gilbens-starkware
left a comment
There was a problem hiding this comment.
@gilbens-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on alon-f and leo-starkware).
crates/circuits/src/finalize_constants.rs line 32 at r1 (raw file):
/// - Base decomposition (with a dynamic base B) for larger M31 values. /// - Broadcast optimization for constants of the form `(x, x, x, x)`. /// - QM31 basis combination (`i`, `u`, `iu`) for general extension-field constants.
Suggestion:
/// Yields and constrains every constant in `context.constants()` via arithmetic gates,
/// All constants are derived from the QM31 extension element `u = (0, 0, 1, 0)` by using:
/// - A `+1` chain for consecutive M31 integer constants.
/// TODO:
/// - Base decomposition (with a dynamic base B) for larger M31 values.
/// - Broadcast optimization for constants of the form `(x, x, x, x)`.
/// - QM31 basis combination (`i`, `u`, `iu`) for general extension-field constants.
gilbens-starkware
left a comment
There was a problem hiding this comment.
@gilbens-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on alon-f and leo-starkware).
crates/circuits/src/finalize_constants.rs line 32 at r1 (raw file):
/// - Base decomposition (with a dynamic base B) for larger M31 values. /// - Broadcast optimization for constants of the form `(x, x, x, x)`. /// - QM31 basis combination (`i`, `u`, `iu`) for general extension-field constants.
Thinking about it it'll be too annoying down the stack, ignore.
leo-starkware
left a comment
There was a problem hiding this comment.
@leo-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on alon-f and gilbens-starkware).
crates/circuits/src/finalize_constants.rs line 21 at r1 (raw file):
/// is to make testing easier by choosing a smaller minimum base. // TODO(Leo): remove allow once integrated in the main flow. #[allow(unused)]
clippy complains with "error: this lint expectation is unfulfilled", i guess because it used in a test

No description provided.