Skip to content

Verify the value of u in the CircuitStatement logup sum. #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leo-starkware wants to merge 1 commit into
base: leo/constants_5
Choose a base branch
from
+10 −3
Draft

Verify the value of u in the CircuitStatement logup sum. #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/circuit_verifier/src/statement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ use stwo_constraint_framework::preprocessed_columns::PreProcessedColumnId;

// TODO(ilya): Update this to the correct values.
pub const INTERACTION_POW_BITS: u32 = 20;
pub const U_ADDRESS: usize = 2;

pub struct CircuitStatement<Value: IValue> {
pub components: IndexMap<&'static str, Box<dyn CircuitEval<Value>>>,
Expand Down Expand Up @@ -80,14 +81,20 @@ impl<Value: IValue> Statement<Value> for CircuitStatement<Value> {
interaction_elements: [Var; 2],
) -> Var {
let mut sum = context.zero();
let zero = context.zero();
let one = context.one();

// Output gates public logup sum contribution.
let gate_relation_id = context.constant(GATE_RELATION_ID.into());
for (output_address, output_value) in zip_eq(&self.output_addresses, &self.output_values) {
let [output_value_0, output_value_1, output_value_2, output_value_3] =
Simd::unpack(context, &Simd::from_packed(vec![*output_value], 4))
.try_into()
.unwrap();
if output_address.get().idx == U_ADDRESS {
[zero, zero, one, zero]
} else {
Simd::unpack(context, &Simd::from_packed(vec![*output_value], 4))
.try_into()
.unwrap()
};
let term = logup_use_term(
context,
&[
Expand Down
Loading