fix: Grant unlock point per badge instead of per badge level #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good. Thanks much 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine the number badge-based unlock points, the current implementation does a
COUNTof badges>= $level, with$levelbeing the configured badge level for any unlock points (usually2= veteran). However, if a player has both the level2and level3badge, they receive two unlock points, since both are counted.This sets the maximum number of badge-based unlock points to 14 (7 badges * 2 points per level). Which is nonsense because it results in the number of overall obtainable points (14 badge + 7 rank = 21) being higher than the number of things to unlock (7 classes * 2 unlocks = 14). Meaning a player who has all weapons unlocked will receive an unlock prompt without anything to unlock.