Revamp scene and marker wall views #5816
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wall view had a series of issues, particularly on smaller viewports. This PR uses the
react-photo-gallerycomponent used in the image wall view to layout the items. It maintains the existing options - that is, sound on hover and show title/tags.Scene wall (shown with titles turned on):
Like the gallery wall, it shows the performers.
Marker wall:
(it looks better in motion)
Per the existing behaviour, it shows the title/primary tag, time and marker tags.
We can use
targetRowHeighton the gallery component to set different display sizes, if we wanted to add zoom functionality in future (or if we want a different default size). I have set it to250currently. I'm happy to adjust the size based on feedback.Regressions on the existing behaviour are that it no longer zooms a preview when moused over, and on smaller viewports (larger than mobile) you won't get 5 items per row.