-
-
Notifications
You must be signed in to change notification settings - Fork 978
FR: Change Career Length to Career Start and Career End #6449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
This pull request has been mentioned on Stash. There might be relevant details there: https://discourse.stashapp.cc/t/stash-v0-31-release-development-thread/4881/1 |
The migration should migrate existing The mutation resolvers need to interpret the deprecated The import/export functionality needs to be updated with the new fields and handle the legacy field. |
|
Honestly, I didn't even know you could do a post migration like that. I was curious how we were going to handle moving the data to the new field without having to have users retag all their stuff. Will more than likely start working on stuff tomorrow. Thanks for the info 👍 |
This is my first attempt at a pretty large front and backend change PR. Please be gentle.
Adds
career_startandcareer_endinteger fields to the Performer model, aligning with StashDB's format. The existingcareer_lengthstring field is now deprecated and computed from the new fields for backwards compatibility.Closes: #3348
Changes
migration 76_performer_career_dates.up.sqlto addcareer_startandcareer_endinteger columns to the performers tableappSchemaVersionto 76GraphQL Schema
career_startInt andcareer_endInt fields to:Performer typePerformerCreateInputPerformerUpdateInputBulkPerformerUpdateInputScrapedPerformertypeScrapedPerformerInputcareer_lengthfield with reason "Use career_start and career_end"Backend
CareerStartandCareerEndfields to:Performer modelstructPerformerPartialstructperformerRowSQLite structScrapedPerformerstructCareerLengthresolver that computes the display string fromcareer_startandcareer_end, with fallback to storedcareer_lengthfor backwards compatibilityToPerformermethod to convert scraped string values to integersFrontend
career_lengthinput field fromPerformerEditPanelcareer_startandcareer_endnumber input fields toPerformerEditPanelPerformerScrapeDialogto showcareer_startandcareer_endinstead ofcareer_lengthPerformerModalto display and savecareer_startandcareer_endcareer_startandcareer_endStashBox Integration
performerFragmentToScrapedPerformerto populateCareerStartandCareerEndfrom StashDB'sCareerStartYearandCareerEndYearSubmitPerformerDraftto useCareerStartandCareerEnddirectly when submitting to StashBox, with fallback to parsingCareerLengthfor backwards compatibilityBackwards Compatibility
career_lengthpopulated will continue to display correctly via the resolver fallbackcareer_lengthfield remains in the GraphQL API (deprecated) and is computed from the new fields when available