[5.x] Normalize query string when creating nocache session #11545
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
commented
Mar 7, 2025
| #[Test] | ||
| public function it_normalizes_query_string() | ||
| { | ||
| $this->get('/test?utm_source=linkedin.com&utm_medium=referral&utm_campaign=foo'); |
There was a problem hiding this comment.
When I comment out my changes in the ServiceProvider this test continues to pass.
It looks like Laravel is normalizing the query string itself in tests, which doesn't happen when I'm testing using Herd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
{{ nocache }}tag when used on a URL with "unsorted" query parameters, where the nocache regions wouldn't be returned after the inital page load.We're already normalizing the query string before looking up a nocache session, just not when we create the nocache session.
Fixes #11543.