[5.x] Fix carbon deprecation warning #11561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11553
This is already fixed in v6 but this backports it.
Context:
Sometimes
$value
is already aCarbon
instance.When you pass a Carbon instance to
createFromFormat
, you get anInvalidFormatException
.The
catch
will catch it, and pass the Carbon instance intoparse
, which just returns the instance back and logs the deprecation warning. We can avoid all that by just returning a Carbon instance early.