Skip to content

Conversation

liucf
Copy link
Contributor

@liucf liucf commented Apr 7, 2025

fixed #11263

@liucf liucf closed this Apr 7, 2025
@liucf liucf force-pushed the fix/issue-11663 branch from 94c3d16 to bb58cfd Compare April 7, 2025 08:40
@liucf liucf reopened this Apr 7, 2025
@duncanmcclean
Copy link
Member

Would you be able to add a test for this fix? We have tests for the collection:previous/next tags in CollectionTest.

@liucf
Copy link
Contributor Author

liucf commented Apr 7, 2025

@duncanmcclean Added test. This bug only occurs when using 'driver' => 'file'. The test suite runs with SQLite, which uses the 'eloquent' driver, so it doesn't catch this bug.

However, when testing it manually through the browser with the 'file' driver, this PR does fix the issue.

@duncanmcclean
Copy link
Member

Thanks!

@jasonvarga
Copy link
Member

I think this looks good, but since it's a change in the base query builder class, this would potentially effect much more than just the collection:next/prev tag so I want to do a little more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buggy {{ collection:previous|next }} in collection with date and time enabled

3 participants