-
-
Notifications
You must be signed in to change notification settings - Fork 575
[6.x] Elevated Sessions #11688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[6.x] Elevated Sessions #11688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
commented
Apr 24, 2025
Otherwise, `$user->password()` will error out when storing users in a database.
…rd. When you update your own you have to enter your own password anyway.
If we want to use that for reasons other than testing, a timestamp is more accurate.
- When middleware is on a route that is accessed directly, redirect to a form page. - Middleware throws an exception - The exception will render json or perform appropriate redirect - Middleware test uses an actual route so redirects can be tested
…checking ... Say you have the expiration set to 1 hour. Someone elevates. Their expiry is 1 hour in the future. You change the config to 15 minutes. The user is still elevated for the whole hour. This change allows the config to be changed and existing sessions will comply.
This was added to confirm passwords while impersonating. If you have permission to impersonate anyway, it's not really preventing anything.
…son. Update test expectation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the concept of "elevated sessions", which prompts you for your password before allowing you to take certain actions. Similar to GitHub's sudo mode.
After "starting" an elevated session, you won't be prompted for your password again until the session expires. By default, elevated sessions last for 15 minutes.
For now, I've implemented this in front of the following actions:
We'll also use this in #11664 before allowing you to view recovery codes, or deactivate 2FA on your account.
Extending
Addon developers can require elevated sessions in their code by applying the
RequireElevatedSession
middleware to applicable routes, and using therequireElevatedSession
JS function.