Show exception messages in build output when fork is installed

[imacrayon]

This PR prevents exception messages from being swallowed by build tasks.

My SSG config is set to fail on errors:

// config/statamic/ssg.php

'failures' => 'errors',

I ran into a situation today where my build started failing and the the only console output I got was:

[✔] Gathered content to be generated

Static site generation failed.

After digging in I found that any GenerationFailedException thrown inside a build task's closure is ignored and only the closure's return value is captured by the calling method.

I updated the task closures so that they will now return an exception message instead of throwing, then the calling method (createContentFiles), will check for an exception message in the results and throw an exception from outside a task loop.

With this change the build output will now appear like this:

[✔] Gathered content to be generated
[✘] /page (Exception message here)
Static site generation failed.

[jasonvarga]

Apologies for the delay.

On the main branch, I'm throwing an exception manually from 2 pages. It seems to work fine:

if (in_array($this->data->slug(), ['page-3', 'page-6'])) {
    throw new \Exception('Page 3 and 6 dont work.');
}

When I set 'failures' to 'errors', it fails immediately with the proper exit code after the first error:

I must be misunderstanding the issue, would you mind clarifying?

[imacrayon]

Hey, no worries, I honestly forgot I submitted this lol

So I ran a quick test and it looks like the output I'm getting is because I'm using spatie/fork. If I remove fork I get output like your screenshot.

[jasonvarga]

I don't see a difference with or without fork. Weird. 🤔

[jasonvarga]

Nevermind, I can confirm what you're saying! I must have been testing on the wrong branch. 😊

On master, without fork:

On master, with fork: