Skip to content
This repository was archived by the owner on Feb 25, 2024. It is now read-only.

Comments

Fixed an issue with horizontal scrolling on Windows not moving canvas correctly#230

Draft
Andarist wants to merge 2 commits intodevfrom
andarist/fix-horizontal-wheeling-windows
Draft

Fixed an issue with horizontal scrolling on Windows not moving canvas correctly#230
Andarist wants to merge 2 commits intodevfrom
andarist/fix-horizontal-wheeling-windows

Conversation

@Andarist
Copy link
Collaborator

@Andarist Andarist commented Aug 30, 2021

fixes #225

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2f2612f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/3MWhZTFqQ8kFsevSXmSAiZxQ26Zd
✅ Preview: https://xstate-viz-git-andarist-fix-horizontal-wheelin-2547f9-statelyai.vercel.app

@Andarist Andarist mentioned this pull request Aug 30, 2021
Open
Andarist
Andarist commented Aug 30, 2021
View reviewed changes
src/CanvasContainer.tsx
if (isMac() || !e.shiftKey) {
canvasService.send(canvasModel.events.PAN(e.deltaX, e.deltaY));
} else {
canvasService.send(canvasModel.events.PAN(e.deltaY, 0));
Copy link
Collaborator Author

@Andarist Andarist Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After playing with this a little bit more I'm unsure if this is the best fix for the issue. It works for this specific case but I'm hesitant to say that it's universally good. It would be quite good if I could only apply this for mouse interactions but as far as I can tell they are indistinguishable from touchpad interactions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Horizontal scroll not working on Windows

1 participant

@Andarist