Skip to content

Conversation

KarelJanVanHaute
Copy link
Contributor

Vite is updated to v6
Typescript is also bumped up.
All other packages are bumped to latest version and packages no loger used are removed.

Tailwind is upgraded to v4.
All @apply's are removed in the component files. This due to the fact that the creator of tailwind css (Adam) is not a huge fan of the @apply. The only @apply's used for now are for the icons.

I've also changed the nesting in some files to be compatible with the native CSS implementation of nesting. This is also supported by lightningcss wich is used under the hood of tailwind v4.

And the tailwind.config.js is removed and the newer full css option is now implemented.

@janhenckens
Copy link
Member

@KarelJanVanHaute Even getest met een nieuwe build en bij yarn watch krijg ik volgende fout:

11:12:21 AM [vite] (client) Pre-transform error: [postcss] /Users/jhenckens/Sites/baseinstall/tailoff/css/site/main.css:4238:9: Unknown word background-color
  Plugin: vite:css
  File: /Users/jhenckens/Sites/baseinstall/tailoff/css/site/main.css:4238:8

@KarelJanVanHaute
Copy link
Contributor Author

@janhenckens Heb je ook eens eerst alle node_modules weggedaan en opnieuw geïnstalleerd?

@janhenckens
Copy link
Member

@janhenckens Heb je ook eens eerst alle node_modules weggedaan en opnieuw geïnstalleerd?

Yep

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@emilyberghen emilyberghen merged commit fdddadf into develop Apr 14, 2025
3 of 4 checks passed
@emilyberghen emilyberghen deleted the KarelJanVanHaute/issue457 branch April 14, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants