Skip to content

Conversation

HannahDeWachter
Copy link
Contributor

Also replace all Social Media fields by 1 reusable field

Also replace all Social Media fields by 1 reusable field
@HannahDeWachter HannahDeWachter linked an issue May 5, 2025 that may be closed by this pull request
@janhenckens janhenckens requested a review from Copilot May 5, 2025 12:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a reusable URL field to replace multiple social media fields, streamlining field configurations. Key changes include:

  • Adding a new URL field configuration file.
  • Updating the project config and entry type layouts to use the reusable URL field for social media.
  • Revising license keys across several plugins.

Reviewed Changes

Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/project/project.yaml Updated timestamps and license keys; removed individual social media field entries.
config/project/fields/urlField--f694fce1-48ca-4bfe-9fba-196195547a36.yaml Added new URL field configuration.
config/project/fields/plainTextTranslatable--8be24311-d95b-441d-aeed-00461fcc4cc4.yaml New configuration for a translatable text field.
config/project/fields/plainTextNotTranslatable--c09b8e44-9631-46c1-85d0-53b43a35c2c6.yaml New configuration for a non-translatable text field.
config/project/fields/lightswitchDefaultOn--78e118aa-917a-44df-977e-7eb1c9b7709a.yaml Added lightswitch field with default on.
config/project/fields/lightswitchDefaultOff--b58b47cd-c00d-4ef4-8246-c8c52949c561.yaml Added lightswitch field with default off.
config/project/entryTypes/contact--f2d8b097-d5ba-4224-9736-4dc41bd6580f.yaml Updated field layout to reference a single reusable URL field for social media with distinct handles and labels.
Files not reviewed (5)
  • config/project/fields/facebook--f694fce1-48ca-4bfe-9fba-196195547a36.yaml: Language not supported
  • config/project/fields/instagram--9bc4b9f2-7fc6-48b0-a3df-8e9c061a70c6.yaml: Language not supported
  • config/project/fields/linkedin--ce1fab3c-0b02-49d8-8d8f-1bab2d7c05e2.yaml: Language not supported
  • config/project/fields/twitter--2e4b3bb0-26e4-47d2-9445-54401a221c63.yaml: Language not supported
  • config/project/fields/youtube--6221c006-75b9-4fa5-a352-4cd4317fb5d7.yaml: Language not supported
Comments suppressed due to low confidence (2)

config/project/entryTypes/contact--f2d8b097-d5ba-4224-9736-4dc41bd6580f.yaml:141

  • [nitpick] The reusable URL field is now referenced for multiple social media entries (Facebook, Twitter, LinkedIn, Instagram, Youtube). Please verify that each instance can reliably store and distinguish between platform-specific URLs, potentially by associating a platform identifier with each entry.
fieldUid: f694fce1-48ca-4bfe-9fba-196195547a36 # URL field

config/project/entryTypes/contact--f2d8b097-d5ba-4224-9736-4dc41bd6580f.yaml:13

  • [nitpick] Multiple hardcoded 'dateAdded' timestamps appear throughout the layout. Consider ensuring these values are generated or maintained uniformly to reduce potential discrepancies in tracking field layout changes.
dateAdded: '2025-04-14T07:57:11+00:00'

Copy link

@SarahOorts SarahOorts merged commit f4ea2f5 into develop May 14, 2025
4 checks passed
@SarahOorts SarahOorts deleted the 419-add-reusable-fields branch May 14, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reusable fields for Craft 5

3 participants