Improve Formie stencils #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to improve the Formie stencils and update the overall configuration for the Formie plugin. Key changes include:
- Updating various configuration values in project.yaml for better type consistency and adding new plugin settings.
- Modifying form stencil configurations for NL, FR, and EN with updated template IDs and submission title formats.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/project/project.yaml | Updated modification date, type conversions for several plugin options, and added new configuration values to enhance functionality. |
| config/project/formie/stencils/contactForm_NL--b1ca80f0-4eed-4f99-bebc-bca6c694cb00.yaml | Updated the stencil to set a specific template rather than null. |
| config/project/formie/stencils/contactForm_FR--68c6a8e9-4391-473a-8b44-293bb38d1f32.yaml | Changed submission title format to include an email field reference and updated the template ID. |
| config/project/formie/stencils/contactForm_EN--ac589bc4-75c7-4f97-b57b-61025fc0643f.yaml | Adjusted the submission title format to include the email address field and updated the template ID. |
Comments suppressed due to low confidence (2)
config/project/formie/stencils/contactForm_FR--68c6a8e9-4391-473a-8b44-293bb38d1f32.yaml:416
- [nitpick] The email field reference 'eMail' appears inconsistent with the 'emailAddress' format used in the EN stencil; consider standardizing this for consistency.
submissionTitleFormat: '{field:eMail}-{timestamp}'
config/project/project.yaml:438
- Changing ajaxTimeout from a string ('10') to a number (10) improves type consistency; please confirm that any code consuming this value expects a numeric type.
ajaxTimeout: 10
SarahOorts
approved these changes
May 15, 2025
|
SarahOorts
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.