Skip to content

DPSTAT-1397 updating build for trivy#47

Merged
salma-tfb merged 12 commits intomasterfrom
DPSTAT-1397-trivy-scanning
Jan 26, 2026
Merged

DPSTAT-1397 updating build for trivy#47
salma-tfb merged 12 commits intomasterfrom
DPSTAT-1397-trivy-scanning

Conversation

@salma-tfb
Copy link
Contributor

@salma-tfb salma-tfb commented Jan 22, 2026

This change is Reviewable

@github-actions github-actions bot added the ci Continuous Integration label Jan 22, 2026
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@skykanin skykanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to fail the build if we find high or critical vulnerabilities using an action like the one below. Therefore all trivy related actions should run before we deploy the JAR to our google artifact registry and the deploy step must only be run if no high or critical vulnerabilities are found.

- name: Fail build on High/Criticial Vulnerabilities
  uses: aquasecurity/trivy-action@master
  with:
    scan-type: "fs"
    format: table
    scan-ref: .
    severity: HIGH,CRITICAL
    ignore-unfixed: true
    exit-code: 1
    # On a subsequent call to the action we know trivy is already installed so can skip this
    skip-setup-trivy: true

@salma-tfb salma-tfb requested a review from skykanin January 23, 2026 11:03
Copy link
Contributor

@skykanin skykanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykanin made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @salma-tfb).


.github/workflows/build.yml line 29 at r2 (raw file):

      - name: Build with Maven
        run: mvn --batch-mode -P ssb-bip package

We should rename this maven profile to ssb-gar (for google artifact registry) as the BIP platform no longer exists.

@salma-tfb salma-tfb requested a review from skykanin January 26, 2026 07:40
skykanin
skykanin previously approved these changes Jan 26, 2026
Copy link
Contributor

@skykanin skykanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykanin reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @salma-tfb).

Copy link
Contributor

@skykanin skykanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykanin resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @salma-tfb).

@salma-tfb salma-tfb merged commit 99ea62e into master Jan 26, 2026
8 of 9 checks passed
@salma-tfb salma-tfb deleted the DPSTAT-1397-trivy-scanning branch January 26, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants