Merged
Conversation
* remove_dotenv: move to conftest * remove_dotenv: remove dependency
* more_integration_tests: new datastore resouce dirs * more_integration_tests: add to common functions * more_integration_tests: add rollback tests * more_integration_tests: fix * more_integration_tests: fix
* reintroduce_unit_tests: adapter tests * reintroduce_unit_tests: config tests * reintroduce_unit_tests: manager tests * reintroduce_unit_tests: worker tests * reintroduce_unit_tests: fix resources * reintroduce_unit_tests: fixes manager test * reintroduce_unit_tests: fixes * reintroduce_unit_tests: missing gitkeep * reintroduce_unit_tests: fix imports * reintroduce_unit_tests: test fixes
* pin_actions: better security (#210) * Use variables from env in workflow scripts * remove double env in workflow-step * update INTEGRATION_TEST_WORKFLOW and DEPLOY_WORKFLOW in env * Update urllib3 * Check tmp dir of all datastores --------- Co-authored-by: linnbjornerud <linnchb@gmail.com> Co-authored-by: Linn Bjørnerud <125447659+linnbjornerud@users.noreply.github.com>
* extra_assertions_integration_tests: added metadata update assertions * extra_assertions_integration_tests: more assertions, update resources * extra_assertions_integration_tests: update dependencies * extra_assertions_integration_tests: ruff
|
Collaborator
Author
|
@statisticsnorway/microdata-developers this is now ready for review |
linnbjornerud
approved these changes
Jan 13, 2026
Contributor
linnbjornerud
left a comment
linnbjornerud
left a comment
There was a problem hiding this comment.
Based on the walkthroughs we have had with the team of the changes/updates to the app code and the test-improvements, I think this overall looks very good.
I have also looked through the integration tests, and think they look very good.
The tests and resources are well organized and feels clean imo 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multitenancy tests
In order to improve tests and their readability, we opted to start from scratch to structure the tests in a more resonable way. The PR has already grown gigantic so I am electing to post this for review first, and I will merge smaller branches into this one a smaller piece at a time.
This branch contains: