Skip to content

Added tests for parquedit.py#4

Merged
roarv2 merged 2 commits intomainfrom
testminimum
Jan 29, 2026
Merged

Added tests for parquedit.py#4
roarv2 merged 2 commits intomainfrom
testminimum

Conversation

@roarv2
Copy link
Contributor

@roarv2 roarv2 commented Jan 29, 2026

Changes summary

  • Updated multiline SQL string formatting in src/ssb_parquedit/parquedit.py for attach, create table from parquet, and fill table operations.
  • Minor whitespace cleanup in docs/conf.py and noxfile.py.
  • Added comprehensive unit tests in tests/test_parquedit.py covering initialization, context management, validation, schema translation, table creation from DataFrame/Parquet, partitioning, description, and fill behaviors.
  • Purpose: Improve code style/readability and significantly increase test coverage and behavior verification.
  • Overall code quality: Testing depth improved with clear isolation via dependency stubbing. The parquedit.py edits are style-only but risk changing whitespace in SQL strings; behavior likely unchanged. No security-sensitive changes introduced.

@sonarqubecloud
Copy link

@roarv2 roarv2 requested review from a team and osn-bip January 29, 2026 11:12
@roarv2 roarv2 merged commit 0493fde into main Jan 29, 2026
18 checks passed
@roarv2 roarv2 deleted the testminimum branch January 29, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants