Skip to content

feat: methods for removing single overrides #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/js-local-overrides/src/LocalOverrideAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ export class LocalOverrideAdapter implements OverrideAdapter {
this._overrides.gate[name] = value;
}

removeGateOverride(name: string): void {
delete this._overrides.gate[name];
}

getGateOverride(
current: FeatureGate,
_user: StatsigUser,
Expand All @@ -52,6 +56,10 @@ export class LocalOverrideAdapter implements OverrideAdapter {
this._overrides.dynamicConfig[name] = value;
}

removeDynamicConfigOverride(name: string): void {
delete this._overrides.dynamicConfig[name];
}

getDynamicConfigOverride(
current: DynamicConfig,
_user: StatsigUser,
Expand All @@ -63,6 +71,10 @@ export class LocalOverrideAdapter implements OverrideAdapter {
this._overrides.experiment[name] = value;
}

removeExperimentOverride(name: string): void {
delete this._overrides.experiment[name];
}

getExperimentOverride(
current: Experiment,
_user: StatsigUser,
Expand All @@ -74,6 +86,10 @@ export class LocalOverrideAdapter implements OverrideAdapter {
this._overrides.layer[name] = value;
}

removeLayerOverride(name: string): void {
delete this._overrides.layer[name];
}

getAllOverrides(): OverrideStore {
return JSON.parse(JSON.stringify(this._overrides)) as OverrideStore;
}
Expand Down
42 changes: 42 additions & 0 deletions packages/js-local-overrides/src/__tests__/LocalOverrides.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,46 @@ describe('Local Overrides', () => {
layer: {},
});
});
it('returns removes single override', () => {
const gateB = _makeFeatureGate('b_gate', { reason: '' }, null);
const dynamicConfigB = _makeDynamicConfig('b_config', { reason: '' }, null);
const experimentB = _makeExperiment('b_experiment', { reason: '' }, null);
const layerB = _makeLayer('b_layer', { reason: '' }, null);

provider.overrideGate(gate.name, true);
provider.overrideDynamicConfig(dynamicConfig.name, { dc: 'value' });
provider.overrideExperiment(experiment.name, { exp: 'value' });
provider.overrideLayer(layer.name, { layer_key: 'value' });

provider.overrideGate(gateB.name, true);
provider.overrideDynamicConfig(dynamicConfigB.name, { dc: 'value' });
provider.overrideExperiment(experimentB.name, { exp: 'value' });
provider.overrideLayer(layerB.name, { layer_key: 'value' });

provider.removeGateOverride(gate.name);
provider.removeDynamicConfigOverride(dynamicConfig.name);
provider.removeExperimentOverride(experiment.name);
provider.removeLayerOverride(layer.name);

expect(provider.getAllOverrides()).toEqual({
dynamicConfig: {
b_config: {
dc: 'value',
},
},
experiment: {
b_experiment: {
exp: 'value',
},
},
gate: {
b_gate: true,
},
layer: {
b_layer: {
layer_key: 'value',
},
},
});
});
});